 Hi Guys
I'm running Dolphin 7.1 something and wondered if there's any way to allow links in comments on photos, videos, blogs and articles... A bit like facebook so if someone posts as url in a comment it automatically gets parsed and turned into a link? If it could be done it would be a great help. |
I am not aware of a way to achieve this in the administration area. function _getCommentBodyBox(&$a)
{
return '
<td class="' . $this->_sStylePrefix . '-cont-l"> </td>
<td class="' . $this->_sStylePrefix . '-cont-m">' .
($this->_aSystem['is_mood'] ? '<div class="cmt-mood">' . $a['cmt_mood'] . '</div>' : '') .
'<div class="cmt-body">' . ($this->iGlobUseTinyMCE || $this->isTagsAllowed() || strncasecmp($a['cmt_text'], '<object', 7) == 0 || strncasecmp($a['cmt_text'], '<iframe', 7) == 0 ? $this->bx_linkify_html($a['cmt_text']) : WordWrapStr($a['cmt_text'])) . '</div>
</td>
<td class="' . $this->_sStylePrefix . '-cont-r"> </td>';
}
function bx_linkify($text, $sAttrs = '', $bHtmlSpecialChars = false)
{
if ($bHtmlSpecialChars)
$text = htmlspecialchars($text, ENT_NOQUOTES, 'UTF-8');
$re = "@\b((https?://)|(www\.))(([0-9a-zA-Z_!~*'().&=+$%-]+:)?[0-9a-zA-Z_!~*'().&=+$%-]+\@)?(([0-9]{1,3}\.){3}[0-9]{1,3}|([0-9a-zA-Z_!~*'()-]+\.)*([0-9a-zA-Z][0-9a-zA-Z-]{0,61})?[0-9a-zA-Z]\.[a-zA-Z]{2,6})(:[0-9]{1,4})?((/[0-9a-zA-Z_!~*'().;?:\@&=+$,%#-]+)*/?)@";
preg_match_all($re, $text, $matches, PREG_OFFSET_CAPTURE);
$matches = $matches[0];
$i = count($matches);
while ($i--)
{
$url = $matches[$i][0];
if (!preg_match('@^https?://@', $url))
$url = 'http://'.$url;
$text = substr_replace($text, '<a ' . $sAttrs . ' href="'.$url.'">'.$matches[$i][0].'</a>', $matches[$i][1], strlen($matches[$i][0]));
}
return $text;
}
/**
* Wrap in A tag links in HTML string, which aren't wrapped in A tag yet
* @param $sHtmlOrig - HTML string
* @param $sAttrs - attributes string to add to the added A tag
* @return modified HTML string, in case of errror original string is returned
*/
function bx_linkify_html($sHtmlOrig, $sAttrs = '')
{
if (!trim($sHtmlOrig))
return $sHtmlOrig;
$sId = 'bx-linkify-' . md5(microtime());
$dom = new DOMDocument();
@$dom->loadHTML('<?xml encoding="UTF-8"><div id="' . $sId . '">' . $sHtmlOrig . '</div>');
$xpath = new DOMXpath($dom);
foreach ($xpath->query('//text()') as $text) {
$frag = $dom->createDocumentFragment();
$frag->appendXML($this->bx_linkify($text->nodeValue, $sAttrs, true));
$text->parentNode->replaceChild($frag, $text);
}
if (version_compare(PHP_VERSION, '5.3.6') >= 0)
$s = $dom->saveHTML($dom->getElementById($sId));
else
$s = $dom->saveXML($dom->getElementById($sId), LIBXML_NOEMPTYTAG);
if (false === $s) // in case of error return original string
return $sHtmlOrig;
if (false !== ($iPos = mb_strpos($s, '<html><body>')) && $iPos < mb_strpos($s, $sId))
$s = mb_substr($s, $iPos + 12, -15); // strip <html><body> tags and everything before them
return mb_substr($s, 54, -6); // strip added tags
}
Let me know if you have any questions or problems. |
Excellent! Thank you! Will give this a try now.
Thanks |
Ok, I've just copied the code you kindly shared above and put it into the BxTemplCmtsView file so that now looks like this: <?php require_once( BX_DIRECTORY_PATH_BASE . 'scripts/BxBaseCmtsView.php' ); /** * @see BxDolCmts */ class BxTemplCmtsView extends BxBaseCmtsView { function _getCommentBodyBox(&$a) { return ' <td class="' . $this->_sStylePrefix . '-cont-l"> </td> <td class="' . $this->_sStylePrefix . '-cont-m">' . ($this->_aSystem['is_mood'] ? '<div class="cmt-mood">' . $a['cmt_mood'] . '</div>' : '') . '<div class="cmt-body">' . ($this->iGlobUseTinyMCE || $this->isTagsAllowed() || strncasecmp($a['cmt_text'], '<object', 7) == 0 || strncasecmp($a['cmt_text'], '<iframe', 7) == 0 ? $this->bx_linkify_html($a['cmt_text']) : WordWrapStr($a['cmt_text'])) . '</div> </td> <td class="' . $this->_sStylePrefix . '-cont-r"> </td>'; } function bx_linkify($text, $sAttrs = '', $bHtmlSpecialChars = false) { if ($bHtmlSpecialChars) $text = htmlspecialchars($text, ENT_NOQUOTES, 'UTF-8'); $re = "@\b((https?://)|(www\.))(([0-9a-zA-Z_!~*'().&=+$%-]+:)?[0-9a-zA-Z_!~*'().&=+$%-]+\@)?(([0-9]{1,3}\.){3}[0-9]{1,3}|([0-9a-zA-Z_!~*'()-]+\.)*([0-9a-zA-Z][0-9a-zA-Z-]{0,61})?[0-9a-zA-Z]\.[a-zA-Z]{2,6})(:[0-9]{1,4})?((/[0-9a-zA-Z_!~*'().;?:\@&=+$,%#-]+)*/?)@"; preg_match_all($re, $text, $matches, PREG_OFFSET_CAPTURE); $matches = $matches[0]; $i = count($matches); while ($i--) { $url = $matches[$i][0]; if (!preg_match('@^https?://@', $url)) $url = 'http://'.$url; $text = substr_replace($text, '<a ' . $sAttrs . ' href="'.$url.'">'.$matches[$i][0].'</a>', $matches[$i][1], strlen($matches[$i][0])); } return $text; } /** * Wrap in A tag links in HTML string, which aren't wrapped in A tag yet * @param $sHtmlOrig - HTML string * @param $sAttrs - attributes string to add to the added A tag * @return modified HTML string, in case of errror original string is returned */ function bx_linkify_html($sHtmlOrig, $sAttrs = '') { if (!trim($sHtmlOrig)) return $sHtmlOrig; $sId = 'bx-linkify-' . md5(microtime()); $dom = new DOMDocument(); @$dom->loadHTML('<?xml encoding="UTF-8"><div id="' . $sId . '">' . $sHtmlOrig . '</div>'); $xpath = new DOMXpath($dom); foreach ($xpath->query('//text()') as $text) { $frag = $dom->createDocumentFragment(); $frag->appendXML($this->bx_linkify($text->nodeValue, $sAttrs, true)); $text->parentNode->replaceChild($frag, $text); } if (version_compare(PHP_VERSION, '5.3.6') >= 0) $s = $dom->saveHTML($dom->getElementById($sId)); else $s = $dom->saveXML($dom->getElementById($sId), LIBXML_NOEMPTYTAG); if (false === $s) // in case of error return original string return $sHtmlOrig; if (false !== ($iPos = mb_strpos($s, '<html><body>')) && $iPos < mb_strpos($s, $sId)) $s = mb_substr($s, $iPos + 12, -15); // strip <html><body> tags and everything before them return mb_substr($s, 54, -6); // strip added tags } function BxTemplCmtsView( $sSystem, $iId, $iInit = 1 ) { BxBaseCmtsView::BxBaseCmtsView( $sSystem, $iId, $iInit ); } }
I've just checked and we're running PHP V5.4.36 so that should be ok shouldn't it?
Have I put it in the right place? I've cleared the cache etc. Thanks |
Note: To test it, I'm posting a simple comment on a photo with just a url in it such as http://www.google.com and crossing my fingers that it turns it into a working link. |
Hi NB :) I just noticed that you have Hypernova installed, so I have attached the file from my install with the working linkify function. Remember to back up any files you are going to change. --------------------------EDIT(2) - because I dont have sufficient permissions to reply again xD |
Hi Thanks for sending the file. It's still not working though. Here's the photo I tested the link on... See the latest comment http://www.railwaymodellers.com/m/photos/view/Possible-Twig-For-Making-Trees
There must be something else that needs altering. I'm running Dolphin 7.1.4. I've not upgraded yet as there's compatibility issues with a couple of modules I use a lot.
Cheers |
Shame :/ |
I got your PM Justin, and a cursory look shows no difference between your file and mine, however I did notice that your version is 7.1.4 and mine is 7.1.6. I will dig deeper when I get some free time and let you know what I find. |
Thank you. Much appreciated. I'll have a look and see if I can patch mine up to 7.1.6 without messing up any modules and hacks! |
All done. |
You're a legend! Thank you! Not a clue about word wrap! What's that?
Can't thank you enough! |
Wordwrap - open a new text file in notepad, paste a really long link into the file (or type a load of characters with no spacing in it.). |
